GH-44713: [Python] Add support for Decimal32 and Decimal64 types #44882
+448
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Python
Component: Documentation
awaiting committer review
|
Please add the concrete classes for the scalars to the list under the Scalars heading in And after you add the Thanks! |
|
Current battles (so I remember them Monday!): I'm missing some member definition for the use-facing type classes: import pyarrow as pa
pa.decimal128(2, 0).precision
#> 2
pa.decimal256(2, 0).precision
#> 2
pa.decimal32(2, 0).precision
#> AttributeError: 'pyarrow.lib.Decimal32Type' object has no attribute 'precision'There's no cast implemented from "float" to "decimal32/64", which at least some of the tests depend on: |
paleolimbot
force-pushed
the
pyarrow-decimal3264
branch
from
8ff213e to
65222c7
Compare
zeroshade
reviewed
Dec 11, 2024
| @@ -180,7 +180,8 @@ def print_entry(label, value): | |||
| ListViewType, LargeListViewType, | |||
| MapType, UnionType, SparseUnionType, DenseUnionType, | |||
| TimestampType, Time32Type, Time64Type, DurationType, | |||
| FixedSizeBinaryType, Decimal128Type, Decimal256Type, | |||
| FixedSizeBinaryType, | |||
| Decimal32Type, Decimal64Type, Decimal128Type, Decimal256Type, | |||
There was a problem hiding this comment.
You'll need to add Decimal32Array, Decimal64Array to line 220 and Decimal32Scalar, Decimal64Scalar to line 229
github-actions
bot
added
awaiting changes
zeroshade
reviewed
Dec 11, 2024
python/pyarrow/types.pxi
Outdated
| Parameters | ||
| ---------- | ||
| precision : int | ||
| Must be between 1 and 9 |
There was a problem hiding this comment.
should update to between 1 and 18
zeroshade
reviewed
Dec 11, 2024
python/pyarrow/tests/test_compute.py
Outdated
| @@ -1900,7 +1900,9 @@ def test_fsl_to_fsl_cast(value_type): | |||
| FloatToDecimalCase = namedtuple('FloatToDecimalCase', | |||
| ('precision', 'scale', 'float_val')) | |||
|
|
|||
| decimal_type_traits = [DecimalTypeTraits('decimal128', pa.decimal128, 38), | |||
| decimal_type_traits = [DecimalTypeTraits('decimal32', pa.decimal32, 8), | |||
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow C++ and the Arrow specification now support 32-bit and 64-bit decimal types...pyarrow should too!
What changes are included in this PR?
Added type, array, and scalar bindings.
Are these changes tested?
Working on it!
Are there any user-facing changes?
Yes! (Working on completing documentation)